Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_launch): add missing parameter in autonmous emergency braking #392

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jun 12, 2023

Description

autowarefoundation/autoware.universe#3292
Add missing parameter in autonomous_emergency_braking.param.yaml for fixing the following error.

'autoware::motion::control::autonomous_emergency_braking::AEB' in container '/control/control_container': Component constructor threw an exception: Statically typed parameter 'collision_keeping_sec' must be initialized.

Tests performed

Not applicable.

Effects on system behavior

Not applicable. (AEB can start normally by this fix. )

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…aking

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@1222-takeshi 1222-takeshi merged commit 6127943 into autowarefoundation:main Jun 12, 2023
@1222-takeshi 1222-takeshi deleted the fix/add_aeb_missing_param branch June 12, 2023 01:59
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
* feat: add-operation-mode-transition-manager

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add param

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants