Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): avoidance shift line processing bug #527

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 24, 2023

Description

autowarefoundation/autoware.universe#4731

Tests performed

  • PASS TIER IV INTERNAL SCENARIOS

Effects on system behavior

Improve avoidance performance.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota marked this pull request as ready for review August 24, 2023 08:43
@satoshi-ota satoshi-ota changed the title fix(avoidance): safety check chattering fix(avoidance): avoidance shift line processing bug Aug 24, 2023
@@ -4,8 +4,6 @@
avoidance:
resample_interval_for_planning: 0.3 # [m]
resample_interval_for_output: 4.0 # [m]
detection_area_right_expand_dist: 0.0 # [m]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this change is applied in the parameter file in the file
but is related to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyoichi-sugahara Thanks for your checking.
I'm sorry fot the confusion. This diff is not related to autowarefoundation/autoware.universe#4731 but is related to autowarefoundation/autoware.universe#4525.

I forgot to remove unused params, and remove them in this PR togather.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i see 👍
Thanks!

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just curious about this change 🤔

@satoshi-ota satoshi-ota merged commit 84188bb into main Aug 25, 2023
16 of 17 checks passed
@satoshi-ota satoshi-ota deleted the feat/chattering-prevention branch August 25, 2023 00:05
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
* fix: fix param file name

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: remove unused parameter

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants