-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): avoidance shift line processing bug #527
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@@ -4,8 +4,6 @@ | |||
avoidance: | |||
resample_interval_for_planning: 0.3 # [m] | |||
resample_interval_for_output: 4.0 # [m] | |||
detection_area_right_expand_dist: 0.0 # [m] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyoichi-sugahara Thanks for your checking.
I'm sorry fot the confusion. This diff is not related to autowarefoundation/autoware.universe#4731 but is related to autowarefoundation/autoware.universe#4525.
I forgot to remove unused params, and remove them in this PR togather.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i see 👍
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but just curious about this change 🤔
* fix: fix param file name Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * feat: remove unused parameter Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
chore: sync awf-latest
Description
autowarefoundation/autoware.universe#4731
Tests performed
Effects on system behavior
Improve avoidance performance.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.