Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): add parameters of real-time covariance estimation #643

Merged
merged 13 commits into from
Nov 7, 2023

Conversation

KOKIAOKI
Copy link
Contributor

Description

Selecting the use of real-time covariance estimation and setting the arrangement of initial position.

Related links

Tests performed

Notes for reviewers

Interface changes

  • use_covariance_estimation
  • offset_array_x
  • offset_array_y

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80fa7e8) 0.00% compared to head (3a3e2ba) 0.00%.
Report is 2 commits behind head on main.

❗ Current head 3a3e2ba differs from pull request most recent head 9b3d5a4. Consider uploading reports for the commit 9b3d5a4 to get more accurate results

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #643   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo self-requested a review November 6, 2023 08:59
KOKIAOKI and others added 2 commits November 6, 2023 19:31
@KOKIAOKI
Copy link
Contributor Author

KOKIAOKI commented Nov 6, 2023

I'm sorry, I forgot to add the parameter.
I added use_covariance_estimation.

Signed-off-by: KOKIAOKI <koki.aoki@map4.jp>
@YamatoAndo YamatoAndo merged commit 916c39c into autowarefoundation:main Nov 7, 2023
9 of 10 checks passed
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Nov 15, 2024
chore(simulator): rename the diagnostic_convertor to scenario_simulator_v2_adapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants