Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplicated_node_checker): enable duplicated_node_checker in simulation #686

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

disabled by this PR
deggresion is solved by this PR

so enable feature in this PR

Tests performed

confirmed in the evaluator

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

simulation

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 064c458 into main Nov 14, 2023
10 of 11 checks passed
@tkimura4 tkimura4 deleted the feat/enable_duplicated_node_checker branch November 14, 2023 06:05
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants