Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointpainting): update parameter structure #778

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 10, 2024

Description

Update parameter structure for pointpainting
autowarefoundation/autoware.universe#4902

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested a review from ktro2828 January 10, 2024 01:34
kminoda and others added 2 commits January 10, 2024 10:37
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit beec828 into autowarefoundation:main Jan 10, 2024
10 checks passed
kminoda added a commit to tier4/autoware_launch that referenced this pull request Jan 10, 2024
* fix(pointpainting): update parameter structure

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update roi_sync.param.yaml

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kminoda added a commit to tier4/autoware_launch that referenced this pull request Jan 10, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants