-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Avrdude build version into avrdude.conf #1542
Conversation
NOTE: I have not tested autotools changes. |
Yes this works fine for CMake build. The latest comit from https://github.com/Youw/avrdude/tree/main is 7cf7c73
|
No problem. And it indeed does not work. But this is okay, we can leave that to @dl8dtl or someone else.
|
I will take the liberty and merge this PR now as it sorted out the issue with the main CMake build system. |
Full build log under MSYS2 mingw64 using auto-tools, just for reference.
|
@mcuee it would be great if you gave us some time to rewiew before merging. There's no rush 😊 I would suggest to move the Avrdude version to the top of the file (or almost at the top) instead of line 436. |
Sorry about this. I was too eager to merge the PR as @Youw is rather busy and I do not want him to spend too much time on this one. Now that the foundation is there, you or others can further improve. |
@@ -543,6 +543,9 @@ AC_CONFIG_FILES([ | |||
Makefile | |||
]) | |||
|
|||
# Pass into avrdude.conf.in | |||
AVRDUDE_FULL_VERSION='$(VERSION)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no autotools expert (nor user for that matter), but my guess is that one more line is missing to make it work:
AC_SUBST(AVRDUDE_FULL_VERSION, $AVRDUDE_FULL_VERSION)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe even:
AC_SUBST(AVRDUDE_FULL_VERSION, '$(VERSION)')
instead
Resolves: #1475