Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Avrdude version number to avrdude.conf using autoconf #1545

Closed
wants to merge 4 commits into from

Conversation

MCUdude
Copy link
Collaborator

@MCUdude MCUdude commented Oct 29, 2023

Resolves #1475.

@stefanrueger I had to comment out avrdude_version, because the grammar complaints:

$ ./avrdude -cpkobn_updi -pavr16eb32
avrdude error: syntax error [/Users/hans/Downloads/avrdude/src/avrdude.conf:435]
avrdude error: unable to process system wide configuration file /Users/hans/Downloads/avrdude/src/avrdude.conf

It would be great if you could push a tiny grammar change to this PR so that this line doesn't have to be commented out. And maybe it can be utilized by Avrdude as well? Potentially warn the user that they're using an old/untested version of avrdude.conf?

@mcuee mcuee added the enhancement New feature or request label Oct 29, 2023
@mcuee
Copy link
Collaborator

mcuee commented Oct 29, 2023

It would be great if you could push a tiny grammar change to this PR so that this line doesn't have to be commented out. And maybe it can be utilized by Avrdude as well? Potentially warn the user that they're using an old/untested version of avrdude.conf?

@MCUdude

Sorry I do not quite understand you you mean by "tiny grammar change". Please help to clarify. Thanks.

@mcuee
Copy link
Collaborator

mcuee commented Oct 29, 2023

@MCUdude

But you are right. git main is broken now. I am sorry. This is an issue caused by PR #1542. I made a mistake and did not test it properly.

PS C:\work\avr\avrdude_test\avrdude_bin> .\avrdude_git -c usbasp -p m2560
avrdude_git error: unable to process system wide configuration file 
C:\work\avr\avrdude_test\avrdude_bin\avrdude.conf

@mcuee mcuee added the bug Something isn't working label Oct 29, 2023
@mcuee
Copy link
Collaborator

mcuee commented Oct 29, 2023

Somehow git main does not like the following line in avrdude.conf and it has to be commented out as of now.

# Buildtime configuration
avrdude_version = "7.2-20231029 (9dfb6164)";

@mcuee
Copy link
Collaborator

mcuee commented Oct 29, 2023

@stefanrueger I had to comment out avrdude_version, because the grammar complaints:

@MCUdude

Actually I think your workaround is not bad. It still serves the purpose.

MINGW64 /c/work/avr/avrdude_test/avrdude_bin
$ head -n 4 ./avrdude_pr1545.conf
# $Id$ -*- text -*-
#
# AVRDUDE 7.2-20231029 (eca4f074) Configuration File
#

@stefanrueger
Copy link
Collaborator

Is this PR still needed once PR #1547 is merged to the (broken) git main?

@mcuee
Copy link
Collaborator

mcuee commented Oct 30, 2023

Is this PR still needed once PR #1547 is merged to the (broken) git main?

@stefanrueger
I think the change to configure.ac is still needed. Maybe you can include that in your PR #1547.
https://github.com/avrdudes/avrdude/pull/1545/files#diff-6cd87b2c1606b89f53692faf681b1e7a8fbf7a2d3a870c4b6ce97ec09a0be906

@mcuee
Copy link
Collaborator

mcuee commented Oct 30, 2023

@MCUdude

I think we can close this PR and then fix the remaining configure.ac change in PR #1547. Is that okay with you?

@MCUdude
Copy link
Collaborator Author

MCUdude commented Oct 30, 2023

I think we can close this PR and then fix the remaining configure.ac change in PR #1547. Is that okay with you?

That's OK!

@mcuee mcuee closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the Avrdude build version to avrdude.conf
4 participants