Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade @parcel/watcher #1045

Merged
merged 3 commits into from
Feb 20, 2024
Merged

downgrade @parcel/watcher #1045

merged 3 commits into from
Feb 20, 2024

Conversation

0618
Copy link
Contributor

@0618 0618 commented Feb 19, 2024

move #1036 to here for e2e test

Problem

npm@10.4 user experience the following error when running npm create amplify

error gyp: binding.gyp not found... while trying to load binding.gyp

Issue number, if available:

#981

parcel-bundler/watcher#156

Changes

  • downgrade @parcel/watcher to 2.1.0

TODO:

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Feb 19, 2024

🦋 Changeset detected

Latest commit: e35f412

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/sandbox Patch
@aws-amplify/backend-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0618 0618 added the run-e2e Label that will include e2e tests in PR checks workflow label Feb 19, 2024
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links to the parcel/watcher issue and npm issue in the PR description and in #1039

@0618 0618 merged commit 88c1b28 into main Feb 20, 2024
36 checks passed
@0618 0618 deleted the parcel-watcher-version branch February 20, 2024 18:27
@devongovett
Copy link

Please try @parcel/watcher v2.4.1, which should fix this issue with npm 10.4.0. See parcel-bundler/watcher#156 (comment) for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants