fix: use standalone ajv validation for model introspection schema #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronZyLee
commented
Apr 11, 2024
There was a problem hiding this comment.
This file is the standalone validation code auto-generated by the Ajv library
AaronZyLee
commented
Apr 11, 2024
There was a problem hiding this comment.
See example code https://ajv.js.org/standalone.html#generating-using-the-js-library
palpatim
reviewed
Apr 11, 2024
packages/appsync-modelgen-plugin/scripts/generateStandaloneValidationFunction.ts
Outdated
Show resolved
Hide resolved
packages/appsync-modelgen-plugin/src/visitors/appsync-model-introspection-visitor.ts
Outdated
Show resolved
Hide resolved
palpatim
approved these changes
Apr 11, 2024
packages/appsync-modelgen-plugin/scripts/generateStandaloneValidationFunction.ts
Show resolved
Hide resolved
phani-srikar
approved these changes
Apr 12, 2024
AaronZyLee
added a commit
that referenced
this pull request
Apr 17, 2024
* build(deps): bump tar from 6.2.0 to 6.2.1 Bumps [tar](https://github.com/isaacs/node-tar) from 6.2.0 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.2.0...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * fix: use standalone ajv validation for model introspection schema (#807) * fix: use standalone ajv validation for model introspection schema * test: add unit tests for validator * fix: missing targetNames in hasOne reference --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dane Pilcher <dppilche@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The direct
Ajvdependency uses a a browser-unsafe eval which will cause a CSP(Content Security Policy) error during runtime. To resolve the issue, the following changes are made:Ajvis removed from dependency but added in dev dependencyAjvlibrary as suggested by the documentation to avoid the unsafe-val method to be used in browser.Codegen Paramaters Changed or Added
Issue #, if available
Description of how you validated changes
Unit & E2E tests
Checklist
yarn testpassespath) behave differently on windows.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.