Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge main into gen2 release #812

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented Apr 17, 2024

Description of changes

This is to fix the issue of the previous tag release version not including the AJV removal commit, which is blocking the data manager testing. The long term solution commit from the main branch is to be merged for the feature branch.

One thing to note there is one snapshot change for hasOne reference codegen, which adds targetNames back as a empty list. This is because the validation fails on previous codegen as targetNames is defined as a required field in hasOne association. Changing it from required to optional is a breaking change. For backward compatibility, I assign the empty list for temporary workaround.

Codegen Paramaters Changed or Added

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified
  • Changes are tested on windows. Some Node functions (such as path) behave differently on windows.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dependabot bot and others added 5 commits April 11, 2024 12:10
Bumps [tar](https://github.com/isaacs/node-tar) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.2.0...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…6.2.1

build(deps): bump tar from 6.2.0 to 6.2.1
* fix: use standalone ajv validation for model introspection schema

* test: add unit tests for validator
@AaronZyLee AaronZyLee requested a review from a team as a code owner April 17, 2024 00:50
@AaronZyLee AaronZyLee merged commit dd31e18 into feature/gen2-release Apr 17, 2024
4 of 5 checks passed
@AaronZyLee AaronZyLee deleted the merge-main-gen2 branch April 17, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants