-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rollback custom user agent internals interface changes #11854
fix: Rollback custom user agent internals interface changes #11854
Conversation
This reverts commit 47d38f4.
…h calls (aws-amplify#11824)" This reverts commit b6987fc.
aws-amplify#11810)" This reverts commit bee9c8e.
…s-amplify#11803)" This reverts commit 10c6868.
…ws-amplify#11755)" This reverts commit 9497c28.
…ify#11606)" This reverts commit 2790f04.
This reverts commit 4115295.
…aws-amplify#11639)" This reverts commit 4d389da.
…mplify#11627)" This reverts commit b0231af.
…ify#11602)" This reverts commit 7365c34.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed list of reverted commits & supporting changes, LGTM
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11854 +/- ##
==========================================
- Coverage 84.08% 83.64% -0.45%
==========================================
Files 350 341 -9
Lines 21173 21579 +406
Branches 4452 4611 +159
==========================================
+ Hits 17804 18049 +245
- Misses 3108 3243 +135
- Partials 261 287 +26 see 38 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description of changes
Having had 3 issues with internals causing duplicate messages we are rolling back this work so that it can be re-tested and introduced again later.
Description of how you validated changes
Running the integ tests for this branch
https://github.com/aws-amplify/amplify-js/actions/runs/5944575383
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.