fix: Rollback custom user agent internals interface changes #11854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 47d38f4.
…h calls (aws-amplify#11824)" This reverts commit b6987fc.
aws-amplify#11810)" This reverts commit bee9c8e.
…s-amplify#11803)" This reverts commit 10c6868.
…ws-amplify#11755)" This reverts commit 9497c28.
…ify#11606)" This reverts commit 2790f04.
This reverts commit 4115295.
…aws-amplify#11639)" This reverts commit 4d389da.
…mplify#11627)" This reverts commit b0231af.
…ify#11602)" This reverts commit 7365c34.
jimblanc
approved these changes
Aug 22, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11854 +/- ##
==========================================
- Coverage 84.08% 83.64% -0.45%
==========================================
Files 350 341 -9
Lines 21173 21579 +406
Branches 4452 4611 +159
==========================================
+ Hits 17804 18049 +245
- Misses 3108 3243 +135
- Partials 261 287 +26 see 38 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kvramyasri7
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Having had 3 issues with internals causing duplicate messages we are rolling back this work so that it can be re-tested and introduced again later.
Description of how you validated changes
Running the integ tests for this branch
https://github.com/aws-amplify/amplify-js/actions/runs/5944575383
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.