Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(required): Amplify JS release #12670

Merged
merged 15 commits into from
Dec 5, 2023
Merged

release(required): Amplify JS release #12670

merged 15 commits into from
Dec 5, 2023

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Dec 4, 2023

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

israx and others added 15 commits November 27, 2023 13:16
chore: fix unknown error typo
…12612)

Revert "Revert "chore: Upgrade Prettier (#12582)" (#12600)"

This reverts commit cd937f5.

Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
* chore: comment and remove failing and not need canaries
* chore: Upgrade Jest

* Address feedback

* Address feedback

* Fix issue with required uuid-validate module

---------

Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
)

chore: add allow-licenses list in dependency_review
…ssr_page` tests fix (#12655)

fix: Build Sample App Tests and integ_next_auth_authenticator_and_ssr_page tests
…test (#12657)

* chore: remove integ_vue_auth_legacy_vue_authenticator test
…ig methods (#12487)

* chore(aws-amplify): add inline docs for Amplify configure and getConfig methods

* Apply suggestions from code review

Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>

---------

Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
* fix: dispatch signInWithRedirect failure event

* chore: add unit tests

* chore: bundle size test

* chore: address feedback

* chore: remove unknown type
@HuiSF HuiSF requested review from a team as code owners December 4, 2023 21:49
Copy link
Contributor

@david-mcafee david-mcafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the assumption that the failing checks will be resolved.

@elorzafe elorzafe merged commit 384adec into release Dec 5, 2023
220 of 222 checks passed
@AllanZhengYP AllanZhengYP mentioned this pull request Dec 11, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants