Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SignIn.vue #6921

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Update SignIn.vue #6921

merged 1 commit into from
Oct 20, 2020

Conversation

sksabircn
Copy link
Contributor

Forget your password? the text has a typo

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Forget your password? the text has a typo
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sksabircn for the catch!

@wlee221
Copy link
Contributor

wlee221 commented Oct 19, 2020

fyi, I'll follow this up with another pr that makes this fix on aws-amplify-react and I18n modules accordingly. Thanks!

@wlee221 wlee221 merged commit 537c10a into aws-amplify:master Oct 20, 2020
sammartinez pushed a commit that referenced this pull request Oct 22, 2020
* fix: fix typo in SignIn.vue (#6921)

Forget your password? the text has a typo

* Rewrite "forget password" to "forgot password"

Co-authored-by: sksabircn <sksabir@capitalnumbers.com>
Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
manueliglesias pushed a commit that referenced this pull request Jan 6, 2021
* fix: fix typo in SignIn.vue (#6921)

Forget your password? the text has a typo

* test: writing tests to cover previously uncovered code

* test: add browser agent detector tests

* test: add build dirs to all jest coverage ignores

* analytics utils coverage and remove unused import from MediaAutoTrack

Co-authored-by: sksabircn <sksabir@capitalnumbers.com>
Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
Co-authored-by: Sam Martinez <samlmar@amazon.com>
CryogenicPlanet pushed a commit to MLH-Fellowship/amplify-js that referenced this pull request Jan 20, 2021
* fix: fix typo in SignIn.vue (aws-amplify#6921)

Forget your password? the text has a typo

* Rewrite "forget password" to "forgot password"

Co-authored-by: sksabircn <sksabir@capitalnumbers.com>
Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
wlee221 added a commit that referenced this pull request May 12, 2021
… speech to text (#7835)

* fix: fix typo in SignIn.vue (#6921)

Forget your password? the text has a typo

* Downsizing sample for some language in speech to text

* adapting test and sendEncodedDataToTranscribe

Co-authored-by: sksabircn <sksabir@capitalnumbers.com>
Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants