Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greater Coverage in Tests #7395

Merged
merged 16 commits into from
Jan 6, 2021
Merged

Greater Coverage in Tests #7395

merged 16 commits into from
Jan 6, 2021

Conversation

harrysolovay
Copy link
Contributor

@harrysolovay harrysolovay commented Dec 11, 2020

Issue #, if available:

Description of changes:

  • Exclude build dirs from inclusion in coverage report
  • Tests for client device info & user agent detection
  • Tests for error messaging
  • Tests for memory storage
  • Fix type error in ServiceWorker tests
  • Tests for Date utils
  • Tests for config parser

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Dec 11, 2020

This pull request fixes 1 alert when merging e823017 into 4b58419 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #7395 (e0789af) into main (e0789af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7395   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         213      213           
  Lines       13375    13375           
  Branches     2530     2530           
=======================================
  Hits         9824     9824           
  Misses       3382     3382           
  Partials      169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0789af...4b53337. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request fixes 1 alert when merging ce16997 into 72997e8 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request fixes 1 alert when merging 2484c61 into 549bab9 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2020

This pull request fixes 1 alert when merging f9f9b02 into 1ee7ebc - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2020

This pull request fixes 1 alert when merging 1408795 into fb4e682 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@harrysolovay harrysolovay marked this pull request as ready for review December 22, 2020 20:07
@lgtm-com
Copy link

lgtm-com bot commented Dec 22, 2020

This pull request fixes 2 alerts when merging 7254144 into a50d23e - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2020

This pull request fixes 2 alerts when merging 375a6d2 into c21e58a - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lGTM, thanks @harrysolovay!

@lgtm-com
Copy link

lgtm-com bot commented Jan 4, 2021

This pull request fixes 2 alerts when merging d1dfdd4 into 06bfecb - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 5, 2021

This pull request fixes 2 alerts when merging 1d18f47 into b3761ae - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2021

This pull request fixes 2 alerts when merging 4b53337 into e0789af - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
@jimblanc jimblanc deleted the coverage-enhancements branch November 23, 2022 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants