Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-amplify/geo): Bumping @aws-sdk/client-location version to fix tslib issues #9234

Closed

Conversation

kmagilavy
Copy link

Description of changes

Bumping @aws-sdk/client-location from 3.22.0 to 3.23.0

Issue #, if available

8967

Description of how you validated changes

Tested locally in app.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kmagilavy kmagilavy changed the title Bumping @aws-sdk/client-location version to fix 8967 tslib issues fix(@aws-amplify/geo): Bumping @aws-sdk/client-location version to fix tslib issues Nov 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #9234 (c16c5a1) into main (d521d17) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9234   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files         250      250           
  Lines       18188    18188           
  Branches     3902     3902           
=======================================
  Hits        14219    14219           
  Misses       3839     3839           
  Partials      130      130           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d521d17...c16c5a1. Read the comment docs.

@sammartinez sammartinez added Geo Related to the Geo category needs-review labels Nov 17, 2021
@TreTuna
Copy link
Contributor

TreTuna commented Nov 18, 2021

Thank you for this PR. I had missed this, but also already had something going on a branch I'm working on to update the sdk client to the latest, so I pulled that out to a different PR #9247 in order to update and that was merged and shipped out just now in the latest versions. If you update to aws-amplify@4.3.8, which uses @aws-amplify/geo@1.1.8, you should see it. If you still see any problems, please let us know!

@TreTuna TreTuna closed this Nov 18, 2021
@kmagilavy
Copy link
Author

kmagilavy commented Nov 20, 2021 via email

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Geo Related to the Geo category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants