Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create relationship rule and validate ImageId on Instance #3513

Merged
merged 7 commits into from
Jul 26, 2024

Clean up the ECS check rule E3049

08420ca
Select commit
Loading
Failed to load commit list.
Merged

Create relationship rule and validate ImageId on Instance #3513

Clean up the ECS check rule E3049
08420ca
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 26, 2024 in 0s

93.61% (+0.06%) compared to fbdd7fa

View this Pull Request on Codecov

93.61% (+0.06%) compared to fbdd7fa

Details

Codecov Report

Attention: Patch coverage is 97.76786% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.61%. Comparing base (fbdd7fa) to head (08420ca).

Files Patch % Lines
src/cfnlint/context/context.py 60.00% 1 Missing and 1 partial ⚠️
src/cfnlint/rules/helpers/get_value_from_path.py 95.45% 1 Missing and 1 partial ⚠️
...cfnlint/rules/resources/ecs/ServiceDynamicPorts.py 98.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3513      +/-   ##
==========================================
+ Coverage   93.54%   93.61%   +0.06%     
==========================================
  Files         343      348       +5     
  Lines       11472    11682     +210     
  Branches     2404     2471      +67     
==========================================
+ Hits        10732    10936     +204     
- Misses        413      415       +2     
- Partials      327      331       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov