Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for rule Equals when static #3659

Merged
merged 1 commit into from
Sep 4, 2024

Better support for rule Equals when static

4d35f22
Select commit
Loading
Failed to load commit list.
Merged

Better support for rule Equals when static #3659

Better support for rule Equals when static
4d35f22
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 4, 2024 in 0s

93.66% (-0.07%) compared to 31d4036

View this Pull Request on Codecov

93.66% (-0.07%) compared to 31d4036

Details

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 93.66%. Comparing base (31d4036) to head (4d35f22).

Files with missing lines Patch % Lines
src/cfnlint/conditions/_rule.py 58.33% 5 Missing ⚠️
src/cfnlint/conditions/conditions.py 64.28% 4 Missing and 1 partial ⚠️
src/cfnlint/conditions/_condition.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
- Coverage   93.73%   93.66%   -0.07%     
==========================================
  Files         356      356              
  Lines       12143    12169      +26     
  Branches     2607     2613       +6     
==========================================
+ Hits        11382    11398      +16     
- Misses        418      426       +8     
- Partials      343      345       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov