Skip to content

Commit

Permalink
remove --aws-account-id flag from deployment (#218)
Browse files Browse the repository at this point in the history
ACK runtime v0.15.0 removed support for the `--aws-account-id`
controller flag but our deployment templates were still adding this flag
to the controller entrypoint args, which causes tests to fail with:

```
unknown flag: --aws-account-id
```

Related: #213

See: aws-controllers-k8s/runtime@6080101

Signed-off-by: Jay Pipes <jaypipes@gmail.com>

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
jaypipes authored Oct 8, 2021
1 parent 46edaac commit 7c52167
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions templates/config/controller/deployment.yaml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ spec:
- command:
- ./bin/controller
args:
- --aws-account-id
- "$(AWS_ACCOUNT_ID)"
- --aws-region
- "$(AWS_REGION)"
- --enable-development-logging
Expand Down
2 changes: 0 additions & 2 deletions templates/helm/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ spec:
- command:
- ./bin/controller
args:
- --aws-account-id
- "$(AWS_ACCOUNT_ID)"
- --aws-region
- "$(AWS_REGION)"
- --aws-endpoint-url
Expand Down

0 comments on commit 7c52167

Please sign in to comment.