remove --aws-account-id flag from deployment

[jaypipes]

ACK runtime v0.15.0 removed support for the --aws-account-id
controller flag but our deployment templates were still adding this flag
to the controller entrypoint args, which causes tests to fail with:

unknown flag: --aws-account-id

Related: #213

See: aws-controllers-k8s/runtime@6080101

Signed-off-by: Jay Pipes jaypipes@gmail.com

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

[jaypipes]

@RedbackThomson in order to get past the test failures, this PR will likely need to be manually merged and then a new release of code-generator cut.

[brycahta]

@RedbackThomson in order to get past the test failures, this PR will likely need to be manually merged and then a new release of code-generator cut.

The test runner, kind-build-test.sh is also using the flag hence the failures.

[brycahta]

/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jaypipes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[surajkota]

@jaypipes @brycahta need to remove from helm charts
https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/helm/values.yaml.tpl#L41

[brycahta]

@jaypipes @brycahta need to remove from helm charts https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/helm/values.yaml.tpl#L41

Functionally , this is fine today right? I agree it should be cleaned up along with its use here: test-helm.sh

[jaypipes]

@jaypipes @brycahta need to remove from helm charts https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/helm/values.yaml.tpl#L41

No, the environment variables are fine. It's just the command-line flag that was at issue.

[RedbackThomson]

@jaypipes @brycahta need to remove from helm charts https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/helm/values.yaml.tpl#L41

No, the environment variables are fine. It's just the command-line flag that was at issue.

We still should remove the Helm value and corresponding environment variable from the templates - they serve no purpose anymore

[jaypipes]

@jaypipes @brycahta need to remove from helm charts https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/helm/values.yaml.tpl#L41

No, the environment variables are fine. It's just the command-line flag that was at issue.

We still should remove the Helm value and corresponding environment variable from the templates - they serve no purpose anymore

They actually do serve a purpose. They allow overriding the GetCallerIdentity results.

[RedbackThomson]

I don't believe setting the environment variable has any effect in the AWS SDK Go - https://github.com/aws/aws-sdk-go/search?q=AWS_ACCOUNT_ID ? Through what mechanism would it override those results?

[jaypipes]

I don't believe setting the environment variable has any effect in the AWS SDK Go - https://github.com/aws/aws-sdk-go/search?q=AWS_ACCOUNT_ID ? Through what mechanism would it override those results?

Sorry, was confusing with AWS_ACCESS_KEY_ID: https://github.com/aws/aws-sdk-go/blob/main/aws/credentials/env_provider.go