Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Resource when GetAttribute is present #439

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Set Resource when GetAttribute is present #439

merged 1 commit into from
Apr 18, 2023

Conversation

arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Apr 18, 2023 •
edited by a-hilaly
Loading

This change basically the SetResource function to continue when the GetAttribute operation is present. If the ReadOne operation is present then that is preferred.

Issue aws-controllers-k8s/community#1778

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@arjunrn
Set Resource when GetAttribute is present
7744a3d 
This change basically the SetResource function to continue when
the `GetAttribute` operation is present. If the `ReadOne` operation is
present then that is preferred.
@ack-prow ack-prow bot requested review from a-hilaly and jljaco April 18, 2023 12:05
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 18, 2023

Hi @arjunrn. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arjunrn arjunrn mentioned this pull request Apr 18, 2023
Closed
jaypipes
jaypipes approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect.

@ack-prow ack-prow bot added the approved label Apr 18, 2023
@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2023
@arjunrn
Copy link
Contributor Author

arjunrn commented Apr 18, 2023

/retest

a-hilaly
a-hilaly approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat +++
Thank you!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, arjunrn, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit e69321e into aws-controllers-k8s:main Apr 18, 2023
@arjunrn arjunrn deleted the support-attribute-set-resource branch April 18, 2023 15:57
@arjunrn arjunrn mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jaypipes jaypipes jaypipes approved these changes

@jljaco jljaco Awaiting requested review from jljaco

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjunrn @a-hilaly @jaypipes