Add primary keys for generator

[arjunrn]

The following resources have ARNs which are set at the primary key:

• PlatformEndpoint
• PlatformApplication
• Topic
• Subscription

Issue aws-controllers-k8s/community#1778

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @arjunrn. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jaypipes]

@arjunrn I don't see any Go code changes after you changed the generator.yaml file, but I do see that you regenerated the controller (since the apis/v1alpha1/ack-generate-metadata.yaml file was updated). So... that tells me that adding these configurations to these fields in the generator.yaml file did not actually have any effect on the generated Go code. This could indicate that for these resources, the SetIdentifiers code path was already working fine by default and that adding the is_arn_primary_key configuration option is mostly just a documentation thing. Is that your understanding as well?

[arjunrn]

@jaypipes It's not changing anything right now because the version of the code generator I used is the one which is currently released and doesn't have the changes I added in aws-controllers-k8s/code-generator#439 . In the current version of the code generator the set identifier is skipped. I added these fields so that when the bot updates the code generator there are no errors during generation because the primary keys cannot be found. I can also update the generator version in this PR and run the generation again. But I assume that's not generally done.

[jaypipes]

@jaypipes It's not changing anything right now because the version of the code generator I used is the one which is currently released and doesn't have the changes I added in aws-controllers-k8s/code-generator#439 . In the current version of the code generator the set identifier is skipped. I added these fields so that when the bot updates the code generator there are no errors during generation because the primary keys cannot be found. I can also update the generator version in this PR and run the generation again. But I assume that's not generally done.

@arjunrn go ahead and regenerate the controller using the version of code-generator that has your fixes :)

[arjunrn]

@jaypipes Updated. There are some other changes from the generator as well.

[jaypipes]

👍 thank you @arjunrn!

[a-hilaly]

/ok-to-test

[a-hilaly]

/lgtm

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, arjunrn, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [A-Hilaly,jaypipes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment