Add cross namespace resource reference support in code generator #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhtm
changed the title
|
/retest |
michaelhtm
force-pushed
the
resource_reference/namespace-support
branch
from
29a44dc to
b75b3fa
Compare
|
/retest |
1 similar comment
|
/retest |
michaelhtm
force-pushed
the
resource_reference/namespace-support
branch
5 times, most recently
from
f8f2534 to
4ba58ad
Compare
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
ack-prow bot
pushed a commit
to aws-controllers-k8s/iam-controller
that referenced
this pull request
Jul 30, 2024
Issue [#1777](aws-controllers-k8s/community#1777) Description of changes: * Adding new e2e test suites to validate our recently introduced feature ["cross namespace resource references"](aws-controllers-k8s/code-generator#532). In order to test this feature, we added a new feature to allow new namespace creation, from which resources will be referenced (Policy in this case). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
approved these changes
Aug 1, 2024
| @@ -117,7 +116,6 @@ func validateReferenceFields(ko *svcapitypes.{{ .CRD.Names.Camel }}) error { | |||
| func (rm *resourceManager) resolveReferenceFor{{ $field.FieldPathWithUnderscore }}( | |||
| ctx context.Context, | |||
| apiReader client.Reader, | |||
| namespace string, | |||
There was a problem hiding this comment.
I like that we're getting rid of unnecessary parameters!
|
|
||
| require ( | ||
| github.com/aws-controllers-k8s/pkg v0.0.12 | ||
| github.com/aws-controllers-k8s/runtime v0.34.0 | ||
| github.com/aws-controllers-k8s/runtime v0.35.1-0.20240719172343-a132c887e8d4 |
There was a problem hiding this comment.
Time to make v0.36.0 release :)
.gitignore
Outdated
Comment on lines
7
to
9
| path/ | ||
| .vscode/ |
There was a problem hiding this comment.
Let's keep only the ones that are somewhat related to ACK
* Added ability to reference resources cross namespace * Needs more testing
michaelhtm
force-pushed
the
resource_reference/namespace-support
branch
from
4ba58ad to
391d445
Compare
|
/retest |
a-hilaly
approved these changes
Aug 5, 2024
ack-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1777
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.