Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross namespace resource references #1777

Closed
a-hilaly opened this issue Apr 17, 2023 · 6 comments
Closed

Cross namespace resource references #1777

a-hilaly opened this issue Apr 17, 2023 · 6 comments
Assignees
@the-cybersapien
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@a-hilaly
Copy link
Member

Currently ACK controllers only allow within-same-namespace resource references . It would be nice to extend this feature to allow cross-namespace references and have a similar experience to resources secret fields. This is technically not very complicated to implement.

Runtime changes:

Code generator changes:

If anyone wanna give this a stab feel free to drop questions in this thread
/good-first-issue
/help-wanted
@a-hilaly a-hilaly added area/code-generation Issues or PRs as related to controllers or docs code generation area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/feature Categorizes issue or PR as related to a new feature. labels Apr 17, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 17, 2023

@a-hilaly:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Currently ACK controllers only allow within-same-namespace resource references . It would be nice to extend this feature to allow cross-namespace references and have a similar experience to resources secret fields. This is technically not very complicated to implement.

Runtime changes:

Code generator changes:

If anyone wanna give this a stab feel free to drop questions in this thread
/good-first-issue
/help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 17, 2023
@the-cybersapien
Copy link

Hi!
I'll take a stab at this!

/assign @the-cybersapien

@the-cybersapien the-cybersapien mentioned this issue Apr 21, 2023
Closed
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 18, 2023

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Dec 18, 2023

Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-prow ack-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 18, 2023
@a-hilaly a-hilaly removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 18, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 15, 2024

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2024
@a-hilaly a-hilaly removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2024
This was referenced Jul 18, 2024
Merged
Merged
ack-prow bot pushed a commit to aws-controllers-k8s/runtime that referenced this issue Jul 19, 2024
@michaelhtm
Add cross namespace resource reference support in runtime (#152)
a132c88 
Issue [#1777](aws-controllers-k8s/community#1777)

Description of changes:
* Added namespace string to AWSResourceReference struct
* Needs testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This was referenced Jul 30, 2024
Merged
Open
ack-prow bot pushed a commit to aws-controllers-k8s/iam-controller that referenced this issue Jul 30, 2024
@michaelhtm
Add tests for cross namespace resource reference (#112)
6b9d0c1 
Issue [#1777](aws-controllers-k8s/community#1777)

Description of changes:
* Adding new e2e test suites to validate our recently introduced feature ["cross namespace resource references"](aws-controllers-k8s/code-generator#532). In order to test this feature, we added a new feature to allow new namespace creation, from which resources will be referenced (Policy in this case).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-prow bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue Aug 5, 2024
@michaelhtm
Add cross namespace resource reference support in code generator (#532)
7c4e088 
Issue [#1777](aws-controllers-k8s/community#1777)

Description of changes:
* Added ability to reference resources cross namespace
* Needs more testing
* Related change in runtime aws-controllers-k8s/runtime#152

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@ack-bot
Copy link
Collaborator

ack-bot commented Dec 14, 2024

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@the-cybersapien the-cybersapien

Labels
area/code-generation Issues or PRs as related to controllers or docs code generation area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a-hilaly @the-cybersapien @ack-bot