Patch the correct observed state after a rm.ReadOne call
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm currently testing this fix with |
ack-bot
added
the
do-not-merge/hold
|
@a-hilaly you may want to update the PR/commit message to mention that |
|
/approve |
For some controllers we noticed an incorrect reconciliation behaviour when a custom hook code was returning a `RequeueNeededAfter` error. More precisely `resourceManager.ReadOne` was not returning the correct observed state when `sdkFind` returns with an error. This bug was causing the reconciler to patch to wrong state (`desird` instead `observed`). This patch fixes this issue by passing the correct observed state to `onError`.
a-hilaly
force-pushed
the
issue807/code-gen
branch
from
d182f73 to
f9fcdb6
Compare
|
@jaypipes Updated, PTAL again. |
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue aws-controllers-k8s/community#807
For some controllers we noticed an incorrect reconciliation behaviour
when a custom hook code was returning a
RequeueNeededAftererror.More precisely
resourceManager.ReadOnewas not returning the correctobserved state when
sdkFindreturns with an error. Which was causingthe reconciler to patch to wrong state (
desirdinsteadobserved).This patch fixes this issue by passing the correct observed state to
onError.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.