CRs are not patched correctly after a rm.ReadOne/sdkFind call
#807
Assignees
Labels
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Comments
ack-bot
added
the
priority/important-soon
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this issue
Jun 7, 2021
Issue aws-controllers-k8s/community#807 For some controllers we noticed an incorrect reconciliation behaviour when a custom hook code was returning a `RequeueNeededAfter` error. More precisely `resourceManager.ReadOne` was not returning the correct observed state when `sdkFind` returns with an error. Which was causing the reconciler to patch to wrong state (`desird` instead `observed`). This patch fixes this issue by passing the correct observed state to `onError`. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Custom Resource seem to not change values when
sdkFind()returns an error. The main reason is thatrm.ReadOneis returningonErrorusing the actual state (r) and not the observed state (observed)/priority important-soon
/assign
The text was updated successfully, but these errors were encountered: