Support suffix exception #97
Conversation
|
Hi @ryansteakley. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-bot
added
the
needs-ok-to-test
ryansteakley
force-pushed
the
affix-exception-check
branch
from
1385cf4 to
089cbf4
Compare
pkg/generate/code/check.go
Outdated
| // config, we return an empty string | ||
| // | ||
| // Sample Output: | ||
| // | ||
| // && strings.HasPrefix(awsErr.Message(), "Could not find model") | ||
| func CheckExceptionMessagePrefix( | ||
| // && strings.HasSuffix(awsErr.Message(), "does not exist.") | ||
| func CheckExceptionMessageAffix( |
There was a problem hiding this comment.
We could also just call this CheckExceptionMessage :)
ryansteakley
force-pushed
the
affix-exception-check
branch
from
089cbf4 to
318990d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson, ryansteakley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
aws-controllers-k8s/community#840
Description of changes:
Add support for suffix exception checking. Also added Sagemaker tests for prefix and suffix exceptions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.