Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support suffix exception messages #840

Closed
ryansteakley opened this issue Jun 18, 2021 · 0 comments
Closed

Support suffix exception messages #840

ryansteakley opened this issue Jun 18, 2021 · 0 comments
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.

Comments

@ryansteakley
Copy link
Member

Is your feature request related to a problem?
Code Generator currently supports prefix check for errors. However certain error messages prefix are not descriptive ex: "ValidationException: ModelPackageGroup arn:aws:sagemaker:us-west-2:accountId:model-package-group/test-package-group does not exist.. Prefix is simply ModelPackageGroup which does not tell us anything.

Describe the solution you'd like
Ability to support suffix check as well certain error messages contain valuable information in the suffix and not the prefix.

Describe alternatives you've considered
A description of any alternative solutions or features you've considered.

@ryansteakley ryansteakley added the kind/enhancement Categorizes issue or PR as related to existing feature enhancements. label Jun 18, 2021
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue Jun 18, 2021
Issue #, if available:
aws-controllers-k8s/community#840

Description of changes:
Add support for suffix exception checking. Also added Sagemaker tests for prefix and suffix exceptions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.
Projects
None yet
Development

No branches or pull requests

1 participant