Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller-bootstrap implementation #1358

Closed
9 tasks done
vijtrip2 opened this issue Jun 21, 2022 · 0 comments
Closed
9 tasks done

controller-bootstrap implementation #1358

vijtrip2 opened this issue Jun 21, 2022 · 0 comments
Assignees
@JamesJHPark
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.

Comments

@vijtrip2
Copy link
Contributor

vijtrip2 commented Jun 21, 2022 •
edited by JamesJHPark
Loading

  • Create a cobra CLI for controller-bootstrap tool
  • create commands, input arguments, and include dummy implementation
  • create Makefile for executing the controller-bootstrap CLI in more user-friendly manner
  • Add various go template files which will be used to bootstrap a controller
  • Implement bootstrapping a new controller repository from scratch
  • Implement updating an existing controller repository's project description files
  • Add simple tests for generating new controller and updating an existing controller
  • Refactor reusable code inside aws-controllers-k8s/pkg repository
  • Automate updating project description files with the latest templates from controller-bootstrap with Prow

Link for design proposal: #1357
@vijtrip2 vijtrip2 added the kind/enhancement Categorizes issue or PR as related to existing feature enhancements. label Jun 21, 2022
@vijtrip2 vijtrip2 moved this to Todo in ACK Core Team Jun 21, 2022
@vijtrip2 vijtrip2 moved this from Todo to In Progress in ACK Core Team Jun 21, 2022
@JamesJHPark JamesJHPark mentioned this issue Jun 22, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jun 22, 2022
@JamesJHPark
Add initial CLI of controller-bootstrap with Makefile (#5)
357b00d 
Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR is to add the initial implementation of controller-bootstrap CLI with subcommand, arguments, and Makefile.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@JamesJHPark JamesJHPark mentioned this issue Jun 22, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jun 24, 2022
@JamesJHPark
Add controller-bootstrap go template files (#6)
e328c9e 
Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR is to add the various go template files which will be used to bootstrap a controller.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This was referenced Jun 27, 2022
Merged
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jun 30, 2022
@JamesJHPark
Make aws-sdk-go, ACK runtime versions, test-infra commit SHA config…
0292330 
…urable in Makefile (#8)

Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR is to make `aws-sdk-go` version, ACK runtime version, and ACK test-infra commit SHA configurable in `Makefile`. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jul 1, 2022
@JamesJHPark
Implement bootstrapping a new controller repository (#7)
1abf835 
Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR adds the initial implementation to bootstrap a new controller repository. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@JamesJHPark JamesJHPark mentioned this issue Jul 4, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jul 5, 2022
@JamesJHPark
Update project description files in an existing controller repository (…
1fc7cfb 
…#9)

Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR is to implement updating an existing controller repository's project description files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This was referenced Jul 5, 2022
Closed
Merged
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jul 11, 2022
@JamesJHPark
Add controller-bootstrap unit test (#11)
c445f5d 
Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR is to add unit test for controller-bootstrap. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@JamesJHPark JamesJHPark mentioned this issue Jul 11, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jul 11, 2022
@JamesJHPark
Add end-to-end tests for controller-bootstrap (#12)
6ceafcb 
Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR is to add end-to-end tests for generating a new controller and updating an existing controller.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit to aws-controllers-k8s/test-infra that referenced this issue Jul 11, 2022
@JamesJHPark
Add presubmit unit test for controller-bootstrap to Prow (#225)
a69375e 
Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- Add the new presubmit unit test for controller-bootstrap to Prow.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@JamesJHPark JamesJHPark mentioned this issue Jul 12, 2022
Closed
RedbackThomson pushed a commit to RedbackThomson/ack-test-infra that referenced this issue Jul 15, 2022
@JamesJHPark
Add presubmit unit test for controller-bootstrap to Prow (aws-control…
a23fbc0 
…lers-k8s#225)

Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- Add the new presubmit unit test for controller-bootstrap to Prow.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@JamesJHPark JamesJHPark mentioned this issue Jul 18, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue Jul 19, 2022
@JamesJHPark
Refactor reusable code to ensure aws-sdk-go repository (#355)
4d9b291 
Signed-off-by: James Park <jamesjhp@amazon.com>

Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- This PR is to refactor reusable code of `EnsureRepo` method and its related methods into the `pkg/` directory of the code-generator repository.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This was referenced Jul 22, 2022
Merged
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jul 26, 2022
@JamesJHPark
Add README.md file for controller-bootstrap (#13)
410c188 
Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- Add `README.md` and modify the contents of `GOVERNANCE.md` and `OWNERS_ALIASES` files for controller-bootstrap.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit to aws-controllers-k8s/test-infra that referenced this issue Jul 26, 2022
@JamesJHPark
Automate updating project description files with Prow (#240)
76e2cac 
Signed-off-by: jamesjhp <jamesjhp@amazon.com>

Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- Add prowjob to automate updating project description files with the latest templates from controller-bootstrap.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@JamesJHPark JamesJHPark mentioned this issue Jul 27, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/controller-bootstrap that referenced this issue Jul 28, 2022
@JamesJHPark
Set API version to the latest API version (#14)
c37cb11 
Signed-off-by: jamesjhp <jamesjhp@amazon.com>

Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- Ensure the API version is set to the latest API version for a service API.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@JamesJHPark JamesJHPark mentioned this issue Jul 28, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/test-infra that referenced this issue Jul 29, 2022
@JamesJHPark
Rename auto-update-controllers.sh to project-static-files.sh (#248)
1447a1d 
Signed-off-by: jamesjhp <jamesjhp@amazon.com>

Issue: [aws-controllers-k8s/community/issues/1358](aws-controllers-k8s/community#1358)

Description of changes:

- Rename `auto-update-controllers.sh` to `project-static-files.sh` and remove Helm from the docker image to update project description files from controller-bootstrap.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Repository owner moved this from In Progress to Done in ACK Core Team Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesJHPark JamesJHPark

Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.
Projects
No open projects
ACK Core Team
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesJHPark @vijtrip2