Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set API version to the latest API version #14

Merged

Conversation

JamesJHPark
Copy link
Contributor

@JamesJHPark JamesJHPark commented Jul 27, 2022

Signed-off-by: jamesjhp jamesjhp@amazon.com

Issue: aws-controllers-k8s/community/issues/1358

Description of changes:

  • Ensure the API version is set to the latest API version for a service API.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: jamesjhp <jamesjhp@amazon.com>
@ack-bot ack-bot requested review from a-hilaly and jaypipes July 27, 2022 22:43
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but technically this will have no effect because there is only a single subdirectory in models/apis/$SERVICE/

@jaypipes
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, JamesJHPark, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit c37cb11 into aws-controllers-k8s:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants