Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GlobalTable resource custom hooks, terminalCodes and e2e tests #4

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Add GlobalTable resource custom hooks, terminalCodes and e2e tests #4

merged 1 commit into from
Jun 14, 2021

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Jun 3, 2021 •
edited
Loading

Part of aws-controllers-k8s/community#803

Description of changes

  • Add custom hooks, terminalCodes to GlobalTable resource in generator.yaml
  • Add e2e tests for GlobalTable create and delete operations

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Jun 3, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-bot ack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2021
@a-hilaly
Copy link
Member Author

a-hilaly commented Jun 3, 2021

Note to reviewers: This PR needs to be rebased once #3 is merged
/hold

@ack-bot ack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@a-hilaly a-hilaly mentioned this pull request Jun 3, 2021
Merged
@a-hilaly a-hilaly changed the title Add GlobalTable resource custom hooks, terminalCodes, printcolumns and e2e tests Add GlobalTable resource custom hooks, terminalCodes and e2e tests Jun 14, 2021
@a-hilaly a-hilaly force-pushed the crd/globaltable branch 2 times, most recently from 3ff9a67 to a3b1c06 Compare June 14, 2021 20:25
@a-hilaly
Add GlobalTable resource custom hooks, terminalCodes and e2e tests
f299aad 
Part of aws-controllers-k8s/community#803

Description of changes
- Add custom hooks and terminalCodes to `GlobalTable` resource in `generator.yaml`
- Add e2e tests for `GlobalTable` create and delete operations

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@a-hilaly a-hilaly marked this pull request as ready for review June 14, 2021 20:27
@ack-bot ack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2021
@a-hilaly
Copy link
Member Author

/ok-to-test

@ack-bot ack-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 14, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 14, 2021

@a-hilaly: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test dynamodb-kind-e2e
  • /test dynamodb-unit-test

In response to this:

/test dynamodb-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member Author

/test dynamodb-kind-e2e

jaypipes
jaypipes approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on this, @a-hilaly. GlobalTable is a weird resource indeed...

@jaypipes
Copy link
Collaborator

/ok-to-test

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member Author

/unhold

@ack-bot ack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@ack-bot ack-bot merged commit 6177f8a into aws-controllers-k8s:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

Assignees

@jaypipes jaypipes

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-hilaly @ack-bot @jaypipes