Add Backup resource custom hooks, terminalCodes and e2e tests
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ack-bot
added
the
do-not-merge/work-in-progress
ack-bot
added
the
do-not-merge/hold
a-hilaly
changed the title
Backup resource custom hooks, terminalCodes, printcolumns and e2e testsBackup resource custom hooks, terminalCodes and e2e tests
|
/unhold |
ack-bot
added
ok-to-test
|
/test dynamodb-kind-e2e |
ack-bot
removed
the
do-not-merge/work-in-progress
jaypipes
reviewed
Jun 15, 2021
RedbackThomson
approved these changes
Jun 15, 2021
|
/test dynamodb-kind-e2e |
|
/retest |
|
Mmmmm it looks like tests are randomly failing from time to time.. investigating that. |
ack-bot
added
the
do-not-merge/hold
Part of aws-controllers-k8s/community#803 Description of changes: - Add custom hooks, terminalCodes to `GlobalTable` resource in `generator.yaml` - Add e2e tests for `Backup` create and delete operations By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
/test dynamodb-kind-e2e |
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of aws-controllers-k8s/community#803
Description of changes:
Backupresource ingenerator.yamlBackupcreate and delete operationsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.