fix: Karpenter eventbridge naming #1483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtherhtun
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
dtherhtun
changed the title
|
|
askulkarni2
reviewed
Mar 14, 2023
| @@ -37,7 +37,7 @@ resource "aws_sqs_queue_policy" "this" { | |||
| resource "aws_cloudwatch_event_rule" "this" { | |||
| for_each = { for k, v in local.event_rules : k => v if var.enable_spot_termination } | |||
|
|
|||
| name = each.value.name | |||
| name = join("-", [each.value.name, var.addon_context.eks_cluster_id]) | |||
There was a problem hiding this comment.
I would prefer using the name_prefix over a fixed name here. Similar to https://github.com/terraform-aws-modules/terraform-aws-eks/blob/c7565e265e23cbc622041fc153193f490cfe948f/modules/karpenter/main.tf#L270.
Suggested change
| name = join("-", [each.value.name, var.addon_context.eks_cluster_id]) | |
| name_prefix = each.value.name |
|
@dtherhtun can you please re-open this PR against https://github.com/aws-ia/terraform-aws-eks-blueprints-addons repo? This is going to be the new home for blueprints addons repo going forward as a part of changes described in #1421. |
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
4 tasks
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the examples to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers.
We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers.
Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue #1421
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes