Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Karpenter eventbridge name_prefix #1495

Merged
merged 14 commits into from
Mar 17, 2023
Merged

Conversation

dtherhtun
Copy link
Contributor

@dtherhtun dtherhtun commented Mar 15, 2023

What does this PR do?

Add optional Karpenter's Event Bridge rules name prefix not to conflict when we create more than one cluster in the same region.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Screenshot 2023-03-15 at 11 17 23

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 As you wish, I closed the previous PR and update name_prefix and docs as well then here is the new PR for that. [Sorry I misunderstood and here is the PR in the new addons repo - https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/pull/11 ]

@dtherhtun dtherhtun requested a review from a team as a code owner March 15, 2023 04:28
Copy link
Contributor

@FernandoMiguel FernandoMiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtherhtun dtherhtun temporarily deployed to EKS Blueprints Test March 16, 2023 02:51 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit dbd9ca3 into aws-ia:main Mar 17, 2023
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Karpenter] Rule with the name already exists on this event bus.
3 participants