Add coverage reports for python packages and manually install python3-boto3 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanewel
approved these changes
Aug 29, 2019
| @@ -5,7 +5,9 @@ set -xe | |||
| apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 421C365BD9FF1F717815A3895523BAEEB01FA116 | |||
| echo "deb http://packages.ros.org/ros/ubuntu `lsb_release -sc` main" > /etc/apt/sources.list.d/ros-latest.list | |||
| apt update && apt install -y python3 python3-pip lcov cmake && rosdep update | |||
| apt update && apt install -y python3-rosinstall python3-colcon-common-extensions && pip3 install -U setuptools | |||
| apt update && apt install -y python3-rosinstall python3-colcon-common-extensions && pip3 install -U setuptools coverage | |||
| # Manually install python3-boto3 (temporary measure until this dependency is available via rosdep). | |||
There was a problem hiding this comment.
Maybe submit an issue for this to track it?
|
Commented out coverage report generation because the equivalent of CATKIN_ENABLE_COVERAGE doesn't exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual installation will be removed once ros/rosdistro#22119 is merged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.