Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-boto3 #22119

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Add python3-boto3 #22119

merged 3 commits into from
Sep 3, 2019

Conversation

AAlon
Copy link
Contributor

@AAlon AAlon commented Aug 29, 2019

This will add the python 3 version of boto3. Needed mainly for ROS2 applications since the Python version is 3 by default so they cannot use the existing python-boto3 key.

debian
fedora
opensuse
ubuntu

Thanks!

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might even be able to drop the Trusty rule but I don't mind keeping it if it brings value to the contributor.

@AAlon
Copy link
Contributor Author

AAlon commented Sep 3, 2019

@nuclearsandwich Just for consistency sake with the python-boto3 key :) we don't really need it.

Is it possible to merge this PR?
Thanks!

@clalancette
Copy link
Contributor

@nuclearsandwich Just for consistency sake with the python-boto3 key :) we don't really need it.

If you don't need it, I'll suggest dropping it completely and just going with the glob rule. Trusty isn't supported anymore anyways, so there is no reason to call it out specifically.

@AAlon
Copy link
Contributor Author

AAlon commented Sep 3, 2019

@nuclearsandwich Just for consistency sake with the python-boto3 key :) we don't really need it.

If you don't need it, I'll suggest dropping it completely and just going with the glob rule. Trusty isn't supported anymore anyways, so there is no reason to call it out specifically.

Sounds good, removed. Wasn't sure if now you'd prefer to reformat the ubuntu rule as ubuntu: [python3-boto3] rather than the asterisk?

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor

I simplified the rule for ubuntu even more (the '*' is superfluous with a single entry). Once CI comes back green, I'll merge.

@clalancette clalancette merged commit c161545 into ros:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants