Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dynamodb): add support for Table Class in Table construct #18718

Closed
1 of 2 tasks
arjanschaaf opened this issue Jan 28, 2022 · 3 comments · Fixed by #18719
Closed
1 of 2 tasks

(dynamodb): add support for Table Class in Table construct #18718

arjanschaaf opened this issue Jan 28, 2022 · 3 comments · Fixed by #18719
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@arjanschaaf
Copy link
Contributor

Description

DynamoDB offers two table classes designed to help you optimize for cost. The DynamoDB Standard table class is the default, and is recommended for the vast majority of workloads. The DynamoDB Standard-Infrequent Access (DynamoDB Standard-IA) table class is optimized for tables where storage is the dominant cost.
https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.TableClasses.html

Support already exists in CloudFormation, but hasn't been implemented in CDK.

Use Case

To create new tables or update existing tables to use the new DynamoDB Standard-IA table class.

Proposed Solution

Extending the Table construct implementation to include this CloudFormation attribute.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@arjanschaaf arjanschaaf added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 28, 2022
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Jan 28, 2022
@arjanschaaf arjanschaaf mentioned this issue Jan 28, 2022
Merged
@nathanagez
Copy link

Hi @skinny85, any idea on when you will be able to merge the PR ? :)

@skinny85 skinny85 removed their assignment Jan 31, 2022
@skinny85 skinny85 added effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2022
@joekendal
Copy link

+1

@mergify mergify bot closed this as completed in #18719 Feb 1, 2022
mergify bot pushed a commit that referenced this issue Feb 1, 2022
@arjanschaaf
feat(dynamodb): allow setting TableClass for a Table (#18719)
73a889e 
Support already exists in CloudFormation, but hasn't been implemented in CDK.

Closes #18718

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@arjanschaaf @TikiTDO
feat(dynamodb): allow setting TableClass for a Table (aws#18719)
c148b7e 
Support already exists in CloudFormation, but hasn't been implemented in CDK.

Closes aws#18718

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dynamodb): allow setting TableClass for a Table
4 participants
@skinny85 @nathanagez @arjanschaaf @joekendal