Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudfront: get default distribution metrics #28893

Closed
1 of 2 tasks
badmintoncryer opened this issue Jan 27, 2024 · 2 comments · Fixed by #28894
Closed
1 of 2 tasks

cloudfront: get default distribution metrics #28893

badmintoncryer opened this issue Jan 27, 2024 · 2 comments · Fixed by #28894
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

CloudFront distributions have default metrics available, but there's a need for metricXyz() that can retrieve these as cloudwatch.Metric objects.

Use Case

Distributions have both additional metrics and default metrics.
While all metric retrieval functions are implemented for additional metrics, it would be very convenient to have similar functions available for default metrics as well.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.123.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 27, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Jan 27, 2024
@badmintoncryer badmintoncryer mentioned this issue Jan 27, 2024
Merged
@pahud
Copy link
Contributor

pahud commented Jan 29, 2024

Thank you for the feature request and we look forward to your PRs.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2024
@mergify mergify bot closed this as completed in #28894 Jan 31, 2024
mergify bot pushed a commit that referenced this issue Jan 31, 2024
@badmintoncryer
feat(cloudfront): retrieve default distribution metrics (#28894)
8e115db 
This PR implements functions to retrieve [default distribution metrics](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/viewing-cloudfront-metrics.html).

```ts
declare const dist: cloudfront.Distribution

const metric = dist.metricRequests()
```

Closes #28893

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
SankyRed pushed a commit that referenced this issue Feb 8, 2024
@badmintoncryer @SankyRed
feat(cloudfront): retrieve default distribution metrics (#28894)
133e399 
This PR implements functions to retrieve [default distribution metrics](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/viewing-cloudfront-metrics.html).

```ts
declare const dist: cloudfront.Distribution

const metric = dist.metricRequests()
```

Closes #28893

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudfront): retrieve default distribution metrics badmintoncryer/aws-cdk
2 participants
@pahud @badmintoncryer