Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepfunctions-tasks: enable resultReuseConfiguration in AthenaStartQueryExecution #30446

Closed
1 of 2 tasks
mazyu36 opened this issue Jun 4, 2024 · 3 comments · Fixed by #30447 or rwlxxvii/containers#185 · May be fixed by gitafolabi/kreuzlaker#2, NOUIY/aws-solutions-constructs#113 or NOUIY/aws-solutions-constructs#114
Closed
1 of 2 tasks

stepfunctions-tasks: enable resultReuseConfiguration in AthenaStartQueryExecution #30446

mazyu36 opened this issue Jun 4, 2024 · 3 comments · Fixed by #30447 or rwlxxvii/containers#185 · May be fixed by gitafolabi/kreuzlaker#2, NOUIY/aws-solutions-constructs#113 or NOUIY/aws-solutions-constructs#114
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jun 4, 2024

Describe the feature

Athena StartQueryExecution supports ResultReuseConfiguration.

But AthenaStartQueryExecution does not support.

Use Case

The "reuse result" feature in Amazon Athena allows you to temporarily cache and reuse the results of a previous query execution, providing significant performance benefits and cost savings when running the same or similar queries repeatedly.

Proposed Solution

Add resultReuseConfiguration to the AthenaStartQueryExecution class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0

Environment details (OS name and version, etc.)

all
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 4, 2024
@mazyu36 mazyu36 mentioned this issue Jun 4, 2024
Merged
1 task
@pahud pahud added p3 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 4, 2024
@pahud
Copy link
Contributor

pahud commented Jun 4, 2024

Thank you @mazyu36 !

@github-actions github-actions bot mentioned this issue Jun 10, 2024
Closed
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
@mergify mergify bot closed this as completed in #30447 Jul 8, 2024
mergify bot pushed a commit that referenced this issue Jul 8, 2024
@mazyu36
feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaS…
046bf56 
…tartQueryExecution (#30447)

### Issue # (if applicable)

Closes #30446.

### Reason for this change
To use  "reuse result" feature in Amazon Athena on Step Functions.



### Description of changes
Add `resultReuseConfiguration` to the `AthenaStartQueryExecution`



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

GavinZZ pushed a commit that referenced this issue Jul 10, 2024
@mazyu36 @GavinZZ
feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaS…
6bc834c 
…tartQueryExecution (#30447)

### Issue # (if applicable)

Closes #30446.

### Reason for this change
To use  "reuse result" feature in Amazon Athena on Step Functions.



### Description of changes
Add `resultReuseConfiguration` to the `AthenaStartQueryExecution`



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaStartQueryExecution mazyu36/aws-cdk
[Snyk] Upgrade aws-cdk-lib from 2.144.0 to 2.153.0 rwlxxvii/containers
[Snyk] Upgrade aws-cdk from 2.44.0 to 2.150.0 gitafolabi/kreuzlaker
[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs
[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs
[Snyk] Upgrade @aws-cdk/cloudformation-diff from 2.99.1 to 2.155.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade aws-cdk from 2.99.1 to 2.155.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade @aws-cdk/cloudformation-diff from 2.99.1 to 2.156.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade aws-cdk from 2.99.1 to 2.156.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade aws-cdk-lib from 2.148.0 to 2.149.0 codu-code/codu
3 participants
@pahud @mazyu36 @aws-cdk-automation