feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaStartQueryExecution #30447

mazyu36 · 2024-06-04T16:51:59Z

Issue # (if applicable)

Closes #30446.

Reason for this change

To use "reuse result" feature in Amazon Athena on Step Functions.

Description of changes

Add resultReuseConfiguration to the AthenaStartQueryExecution

Description of how you validated changes

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

lpizzinidev

Thanks 👍
Left a comment for an initial adjustment on the interface.
Let me know if you have any feedback.

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

…query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

mazyu36 · 2024-06-05T15:44:03Z

@lpizzinidev
Thank you.
I think your suggestion is smarter, so I made revisions including unit tests and integration tests.

lpizzinidev

Thanks 👍 Left comments for some final minor adjustments

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

packages/aws-cdk-lib/aws-stepfunctions-tasks/README.md

…query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

mazyu36 · 2024-06-06T00:41:56Z

@lpizzinidev
Thanks. I have revised again.

lpizzinidev

Thanks 👍 Sorry for suggesting a syntactically wrong error message 🙂

lpizzinidev · 2024-06-06T16:30:54Z

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

+    if (resultReuseConfigurationMaxAge === undefined || cdk.Token.isUnresolved(resultReuseConfigurationMaxAge)) return;
+    const maxAgeInMillis = resultReuseConfigurationMaxAge.toMilliseconds();
+    if (maxAgeInMillis > 0 && maxAgeInMillis < cdk.Duration.minutes(1).toMilliseconds()) {
+      throw new Error(`resultReuseConfigurationMaxAge must be between greater than or equal to 1 minute or 0, got ${maxAgeInMillis} ms`);


Suggested change

throw new Error(`resultReuseConfigurationMaxAge must be between greater than or equal to 1 minute or 0, got ${maxAgeInMillis} ms`);

throw new Error(`resultReuseConfigurationMaxAge must be greater than or equal to 1 minute or 0, got ${maxAgeInMillis} ms`);

Thanks. I fixed it.

paulhcsun

Changes look good to me, just a couple of wording changes for the error messages!

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

…query-execution.ts Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>

mazyu36 · 2024-07-04T13:05:19Z

@paulhcsun
Thank you for the review.
I've changed error messages and unit tests.

paulhcsun

Thanks for your contribution @mazyu36! I've approved the PR but added a do-not-merge label as we're currently holding off on merging anything while fixing a custom resources related issue which touches a lot of integ tests. As with your other PR, this change probably would not affect that but we're pausing all merges temporarily to be safe. We should hopefully be able to get this merged in tomorrow if not sometime next week. Thanks for your patience and understanding! 🙏

mergify · 2024-07-05T17:51:28Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mazyu36 · 2024-07-05T21:59:22Z

@Mergifyio update

mergify · 2024-07-05T21:59:33Z

update

✅ Branch has been successfully updated

mergify · 2024-07-06T01:31:48Z

update

✅ Branch has been successfully updated

Pull request has been modified.

mazyu36 · 2024-07-06T06:58:20Z

@paulhcsun
Thank you for approve.
But integ test failed because of #30108, so I’ve updated.
Could you please approve again?

mergify · 2024-07-08T20:58:41Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-07-08T21:02:47Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-07-08T21:58:05Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 9da4d83
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-07-08T21:58:27Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…tartQueryExecution (#30447) ### Issue # (if applicable) Closes #30446. ### Reason for this change To use "reuse result" feature in Amazon Athena on Step Functions. ### Description of changes Add `resultReuseConfiguration` to the `AthenaStartQueryExecution` ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2024-07-25T20:48:54Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions bot added feature-request A feature should be added or improved. p2 labels Jun 4, 2024

aws-cdk-automation requested a review from a team June 4, 2024 16:52

github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Jun 4, 2024

mazyu36 force-pushed the sfn-athena-start-query-reuse branch from 22c31b7 to d1f2a19 Compare June 4, 2024 17:29

feat: enable ResultReuseConfiguration in AthenaStartQueryExecution

57348a6

mazyu36 force-pushed the sfn-athena-start-query-reuse branch from d1f2a19 to 57348a6 Compare June 4, 2024 17:39

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 4, 2024

lpizzinidev suggested changes Jun 4, 2024

View reviewed changes

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 4, 2024

mazyu36 and others added 3 commits June 5, 2024 23:25

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-…

0d176fd

…query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

fix: incorporate review comments

9495f2f

fix: update README

0904cbc

lpizzinidev suggested changes Jun 5, 2024

View reviewed changes

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Show resolved Hide resolved

packages/aws-cdk-lib/aws-stepfunctions-tasks/README.md Outdated Show resolved Hide resolved

mazyu36 and others added 3 commits June 6, 2024 08:55

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-…

41394da

…query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/README.md

44c6ed9

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

incorporate review comments

19c5637

lpizzinidev approved these changes Jun 6, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 6, 2024

chore: unit test revised

e870a61

github-actions bot mentioned this pull request Jun 10, 2024

Weekly PR metrics report #30506

Closed

github-actions bot mentioned this pull request Jul 1, 2024

Monthly PR metrics report #30715

Closed

paulhcsun reviewed Jul 3, 2024

View reviewed changes

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved

mazyu36 and others added 3 commits July 4, 2024 21:32

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-…

e638293

…query-execution.ts Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-…

09210e3

…query-execution.ts Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>

fix: update unit tests

2e055e8

paulhcsun added the pr/do-not-merge This PR should not be merged at this time. label Jul 4, 2024

paulhcsun previously approved these changes Jul 4, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 4, 2024

Leo10Gama removed the pr/do-not-merge This PR should not be merged at this time. label Jul 5, 2024

Merge branch 'main' into sfn-athena-start-query-reuse

358d323

Merge branch 'main' into sfn-athena-start-query-reuse

936a3e9

Merge branch 'main' into sfn-athena-start-query-reuse

0cd3270

update integ test

5147bef

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 6, 2024

mazyu36 requested a review from paulhcsun July 6, 2024 06:58

Leo10Gama approved these changes Jul 8, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 8, 2024

Merge branch 'main' into sfn-athena-start-query-reuse

9da4d83

mergify bot merged commit 046bf56 into aws:main Jul 8, 2024
9 checks passed

mazyu36 deleted the sfn-athena-start-query-reuse branch July 9, 2024 01:12

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaStartQueryExecution #30447

feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaStartQueryExecution #30447

mazyu36 commented Jun 4, 2024

lpizzinidev left a comment

mazyu36 commented Jun 5, 2024

lpizzinidev left a comment

mazyu36 commented Jun 6, 2024

lpizzinidev left a comment

lpizzinidev Jun 6, 2024

mazyu36 Jun 7, 2024

paulhcsun left a comment

mazyu36 commented Jul 4, 2024

paulhcsun left a comment

mergify bot commented Jul 5, 2024

mazyu36 commented Jul 5, 2024

mergify bot commented Jul 5, 2024

mergify bot commented Jul 6, 2024

mazyu36 commented Jul 6, 2024

mergify bot commented Jul 8, 2024

mergify bot commented Jul 8, 2024

aws-cdk-automation commented Jul 8, 2024

mergify bot commented Jul 8, 2024

aws-cdk-automation commented Jul 25, 2024

	throw new Error(`resultReuseConfigurationMaxAge must be between greater than or equal to 1 minute or 0, got ${maxAgeInMillis} ms`);
	throw new Error(`resultReuseConfigurationMaxAge must be greater than or equal to 1 minute or 0, got ${maxAgeInMillis} ms`);

feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaStartQueryExecution #30447

feat(stepfunctions-tasks): enable resultReuseConfiguration in AthenaStartQueryExecution #30447

Conversation

mazyu36 commented Jun 4, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

lpizzinidev left a comment

Choose a reason for hiding this comment

mazyu36 commented Jun 5, 2024

lpizzinidev left a comment

Choose a reason for hiding this comment

mazyu36 commented Jun 6, 2024

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev Jun 6, 2024

Choose a reason for hiding this comment

mazyu36 Jun 7, 2024

Choose a reason for hiding this comment

paulhcsun left a comment

Choose a reason for hiding this comment

mazyu36 commented Jul 4, 2024

paulhcsun left a comment

Choose a reason for hiding this comment

mergify bot commented Jul 5, 2024

mazyu36 commented Jul 5, 2024

mergify bot commented Jul 5, 2024

✅ Branch has been successfully updated

mergify bot commented Jul 6, 2024

✅ Branch has been successfully updated

mazyu36 commented Jul 6, 2024

mergify bot commented Jul 8, 2024

mergify bot commented Jul 8, 2024

aws-cdk-automation commented Jul 8, 2024

AWS CodeBuild CI Report

mergify bot commented Jul 8, 2024

aws-cdk-automation commented Jul 25, 2024