Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoscaling group should have health check type option #3381

Closed
1 of 5 tasks
lkoniecz opened this issue Jul 22, 2019 · 0 comments · Fixed by #3390
Closed
1 of 5 tasks

Autoscaling group should have health check type option #3381

lkoniecz opened this issue Jul 22, 2019 · 0 comments · Fixed by #3390
Labels
needs-triage This issue or PR still needs to be triaged.

Comments

@lkoniecz
Copy link

lkoniecz commented Jul 22, 2019 •
edited
Loading

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.

  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
    Autoscaling group construct: https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_autoscaling/AutoScalingGroup.html
    should have a way to set health-check type. Currently defaults to EC2

  • What is the expected behavior (or behavior of feature suggested)?
    Either pass it as an attribute or do it via LoadBalancer.add_target or AutoscalingGroup.attach_to_classic_lb methods

  • What is the motivation / use case for changing the behavior or adding this feature?
    ELB health check type is recommended solution and caught as fault tolerance error by AWS Trusted advisor.

  • Please tell us about your environment:

    • CDK CLI Version: 1.0.0 (build d89592e)
    • Module Version: 1.0.0
    • OS: [all]
    • Language: [all]

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)
@lkoniecz lkoniecz added the needs-triage This issue or PR still needs to be triaged. label Jul 22, 2019
@nmussy nmussy mentioned this issue Jul 23, 2019
Merged
eladb pushed a commit that referenced this issue Jul 25, 2019
@nmussy
feat(autoscaling): health check configuration (#3390)
c9a2c21 
Implements missing Auto Scaling Group properties [HealthCheckType](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthchecktype) and [HealthCheckGracePeriod](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthcheckgraceperiod)
They are grouped in a `healthCheck` object property.
The constructor checks that the following requirement is fulfilled:

> If you are adding an ELB health check, you must specify this property.


Fixes #3381
RomainMuller pushed a commit that referenced this issue Jul 25, 2019
@nmussy @RomainMuller
feat(autoscaling): health check configuration (#3390)
9347a71 
Implements missing Auto Scaling Group properties [HealthCheckType](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthchecktype) and [HealthCheckGracePeriod](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthcheckgraceperiod)
They are grouped in a `healthCheck` object property.
The constructor checks that the following requirement is fulfilled:

> If you are adding an ELB health check, you must specify this property.


Fixes #3381
mergify bot pushed a commit that referenced this issue Aug 7, 2019
@RomainMuller @mergify
feat(autoscaling): health check configuration (#3390) (#3436)
76e5173 
Implements missing Auto Scaling Group properties [HealthCheckType](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthchecktype) and [HealthCheckGracePeriod](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthcheckgraceperiod)
They are grouped in a `healthCheck` object property.
The constructor checks that the following requirement is fulfilled:

> If you are adding an ELB health check, you must specify this property.


Fixes #3381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(autoscaling): health check configuration logicgram/aws-cdk
1 participant
@lkoniecz