Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): health check configuration (re-roll) #3436

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Jul 25, 2019

Re-introduce #3390, which was reverted as part of #3435 due to aws/jsii#650.


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Implements missing Auto Scaling Group properties [HealthCheckType](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthchecktype) and [HealthCheckGracePeriod](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthcheckgraceperiod)
They are grouped in a `healthCheck` object property.
The constructor checks that the following requirement is fulfilled:

> If you are adding an ELB health check, you must specify this property.


Fixes #3381
@RomainMuller RomainMuller requested a review from a team as a code owner July 25, 2019 16:06
@RomainMuller RomainMuller added the pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. label Jul 29, 2019
@RomainMuller RomainMuller changed the title feat(autoscaling): health check configuration feat(autoscaling): health check configuration (re-roll) Jul 29, 2019
@rix0rrr rix0rrr assigned RomainMuller and unassigned rix0rrr Aug 7, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 7, 2019

Romain, I'm passing this off to you as I don't have enough state on the release train of jsii, and I suspect you do.

@RomainMuller RomainMuller removed the pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. label Aug 7, 2019
@RomainMuller
Copy link
Contributor Author

I meant to get back to this today anyway... So yeah - the current release of JSII should be working with this correctly; and the dependencies of CDK were already upgraded with the latest release. This is ready to re-roll now!

@mergify mergify bot merged commit 76e5173 into master Aug 7, 2019
@RomainMuller RomainMuller deleted the rmuller/reroll-pr branch August 7, 2019 17:05
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants