feat(cdk): Added SecondsBeforeTimeout, TimeOutAction #27183 #27489

edxlang · 2023-10-11T02:32:20Z

Added secondsBeforeTimeout
Added timeOutAction

Followed coding conventions,
Enacted checks for both seconds before the timeout and time-out action.

Second try, with updated branches and snapshots
Closes #27183.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

AWS Service Spec packages to latest versions.

#27394 added back the synthetics module for CDK release v2.100.0 due to an issue with the peer dependencies that has since been fixed. Since synthetics is stabilized, the alpha module can be safely deleted now. I downloaded `@aws-cdk/aws-synthetics-alpha` version `2.100.0-alpha.0` and confirmed that its `package.json` included the correct peer dependencies with the caret: ```json "peerDependencies": { "aws-cdk-lib": "^2.100.0", "constructs": "^10.0.0" }, ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…rsion of Java (#27422) This change allows users to use more up-to-date java functionality. Java 8 is now only supported in limited circumstances so we should not set that version here. > REPLACE THIS TEXT BLOCK > > Describe the reason for this change, what the solution is, and any > important design decisions you made. > > Remember to follow the [CONTRIBUTING GUIDE] and [DESIGN GUIDELINES] for any > code you submit. > > [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md > [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md Closes #<issue number here>. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…27467) New alpha modules deserve their own labels. Labels themselves have been added. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Reverts #27441 ... snip snap snip snap snip We will be publishing one last version that deprecates the module

Depends on #27470. Deprecates the alpha module for aws-synthetics-alpha so that the last version of aws-synthetics-alpha points to the stable aws-cdk-lib/aws-synthetics. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

There was logic in `aws-glue-alpha.Job` that expected `SparkUIProps.prefix` to be specified in the form `/prefix-name`, instead of the more conventional `prefix-name/`. This fix addresses the validation and handling of this prefix field to support the correct format. BREAKING CHANGE: `SparkUIProps.prefix` strings in the original `/prefix-name` format will now result in a validation error. To retain the same behavior, prefixes must be changed to the new `prefix-name/` format. Closes #27396. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Added `without-urls` option for poetry. Also added Python versions for the integration tests. Closes #27103. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

This PR resolves errors in the integration test library when users run identical assertions multiple times. This change ensures that each use of `awsApiCall`, `httpApiCall`, and `invokeFunction` has a unique identifier, even when multiple identical assertions are used in the same context. We introduced a `uniqueAssertionId` function in the `DeployAssert` construct that maintains backward compatibility with the old id rendering scheme, but prevents the use of conflicting construct ids by tracking the usage of ids and differentiating them where there's a conflict. Closes #22043, #23049 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

The `HttpApiCall` handler only supports endpoints that return JSON. Also let it handle regular strings, if the endpoint returns something that is not parseable as JSON. Fix a type issue in the declared types as well, they never returned a `responseJson` field, just a `body` field. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…ueryExecution` (#27287) Add missing `ExecutionParameters` option to `AthenaStartQueryExecution` step. Closes #27286. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

edxlang · 2023-10-11T02:34:06Z

@scanlonp Hey, just fixed the branching issues and I submitted this new PR to commemorate the moment

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

aws-cdk-automation · 2023-10-11T03:19:44Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: af1ff21
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2023-11-02T00:08:25Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation · 2023-11-09T00:08:27Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation · 2023-11-09T00:10:15Z

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

ed and others added 16 commits October 7, 2023 13:26

init

99f2fcc

ok it works

f9969e8

feat: update AWS Service Spec (#27464)

a4270e4

AWS Service Spec packages to latest versions.

chore(issue-label-assign): aws-scheduler and aws-scheduler-targets (#…

e3e2069

…27467) New alpha modules deserve their own labels. Labels themselves have been added. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

revert: "chore(synthetics): delete alpha module" (#27470)

663ff79

Reverts #27441 ... snip snap snip snap snip We will be publishing one last version that deprecates the module

Merge branch 'aws:main' into PR-Timeout

e2d5cb5

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 11, 2023

aws-cdk-automation requested a review from a team October 11, 2023 02:32

aws-cdk-automation requested changes Oct 11, 2023

View reviewed changes

ed and others added 3 commits October 10, 2023 22:36

adding snapshot, I believe.

5eff589

Merge branch 'main' into PR-Timeout

a6a4318

added integ test and i think snapshot

af1ff21

github-actions bot mentioned this pull request Nov 1, 2023

Monthly PR metrics report - October 2023 #27786

Closed

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Nov 9, 2023

aws-cdk-automation closed this Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cdk): Added SecondsBeforeTimeout, TimeOutAction #27183 #27489

feat(cdk): Added SecondsBeforeTimeout, TimeOutAction #27183 #27489

edxlang commented Oct 11, 2023

edxlang commented Oct 11, 2023

aws-cdk-automation left a comment

aws-cdk-automation commented Oct 11, 2023

aws-cdk-automation commented Nov 2, 2023

aws-cdk-automation commented Nov 9, 2023

aws-cdk-automation commented Nov 9, 2023

feat(cdk): Added SecondsBeforeTimeout, TimeOutAction #27183 #27489

feat(cdk): Added SecondsBeforeTimeout, TimeOutAction #27183 #27489

Conversation

edxlang commented Oct 11, 2023

edxlang commented Oct 11, 2023

aws-cdk-automation left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Oct 11, 2023

AWS CodeBuild CI Report

aws-cdk-automation commented Nov 2, 2023

aws-cdk-automation commented Nov 9, 2023

aws-cdk-automation commented Nov 9, 2023