-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apigatewayv2-integrations): integrations of imported lambda functions do not get configured #27861
Conversation
… configured Signed-off-by: Sumu <sumughan@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
…mbda Signed-off-by: Sumu <sumughan@amazon.com>
… to true in fromFunctionName() Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #18965
HTTPLambdaIntegration
using imported lambda functions are currently not being configured. This is due to the fact that thecanCreatePermissions
property is set to false in imported lambdas, so the lambda permissions are never created.This PR fixes this issue by:
sameEnvironment
property totrue
for lambdas imported usingfromFunctionName()
addPermissions()
function is called on a lambda withcanCreatePermissions
set to false.The new integ test file tests that imported lambdas using
fromFunctionName()
andfromFunctionAttributes()
(withsameEnvironment
set totrue
) work as expected, including on sub-route integrations.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license