Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigatewayv2-integrations): integrations of imported lambda functions do not get configured #27861

Merged
merged 15 commits into from
Nov 20, 2023

Conversation

sumupitchayan
Copy link
Contributor

@sumupitchayan sumupitchayan commented Nov 6, 2023

Closes #18965

HTTPLambdaIntegration using imported lambda functions are currently not being configured. This is due to the fact that the canCreatePermissions property is set to false in imported lambdas, so the lambda permissions are never created.

This PR fixes this issue by:

  • Setting the sameEnvironment property to true for lambdas imported using fromFunctionName()
  • Adding clarification in documentation about imported lambdas needing to belong to the same stack account and region as that of the lambda being imported from be able to add permissions
  • Adding a new warning to be thrown when the addPermissions() function is called on a lambda with canCreatePermissions set to false.

The new integ test file tests that imported lambdas using fromFunctionName() and fromFunctionAttributes() (with sameEnvironment set to true) work as expected, including on sub-route integrations.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… configured

Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan changed the title fix(apigatewayv2-integrations): integrations of referenced lambda function do not get configured fix(apigatewayv2-integrations): integrations of referenced lambda functions do not get configured Nov 6, 2023
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Nov 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 6, 2023 20:36
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 6, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
…mbda

Signed-off-by: Sumu <sumughan@amazon.com>
… to true in fromFunctionName()

Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan changed the title fix(apigatewayv2-integrations): integrations of referenced lambda functions do not get configured fix(apigatewayv2-integrations): integrations of imported lambda functions do not get configured Nov 10, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 10, 2023 18:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@sumupitchayan sumupitchayan marked this pull request as ready for review November 10, 2023 20:20
Signed-off-by: Sumu <sumughan@amazon.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 13, 2023
packages/aws-cdk-lib/aws-lambda/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-lambda/lib/function-base.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 20, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c6d87e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2c21ea0 into main Nov 20, 2023
15 checks passed
@mergify mergify bot deleted the sumughan/apigwv2-fix-subroutes-integration branch November 20, 2023 16:44
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sumupitchayan sumupitchayan added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws_apigatewayv2.HttpLambdaIntegration): add_routes integration to subroute doesn't take affect
3 participants