Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigatewayv2): graduate to stable 🚀 #28094

Merged
merged 68 commits into from
Nov 29, 2023

Conversation

sumupitchayan
Copy link
Contributor

@sumupitchayan sumupitchayan commented Nov 21, 2023

We are excited to graduate the @aws-cdk/aws-apigatewayv2-alpha, @aws-cdk/aws-apigatewayv2-authorizers-alpha, and @aws-cdk/aws-apigatewayv2-integrations-alpha modules to STABLE.

They now live on as:

  • aws-cdk-lib/aws-apigatewayv2
  • aws-cdk-lib/aws-apigatewayv2-authorizers
  • aws-cdk-lib/aws-apigatewayv2-integrations

Deprecated properties removed:

  • httpApiId has been removed in aws-apigatewayv2. Use apiId instead.

P1 Bug Fixes Completed:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
… so check back if build fails later

Signed-off-by: Sumu <sumughan@amazon.com>
@github-actions github-actions bot added the p2 label Nov 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 21, 2023 22:18
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 21, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sumupitchayan sumupitchayan changed the title feat(aws-apigatewayv2): graduate to stable 🚀 feat(apigatewayv2): graduate to stable 🚀 Nov 22, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 22, 2023 16:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

sumupitchayan and others added 3 commits November 22, 2023 12:17
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan marked this pull request as ready for review November 29, 2023 18:08
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 29, 2023
Signed-off-by: Sumu <sumughan@amazon.com>
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumupitchayan approved, but remember to keep track of whoever releases CDK next (I think @mrgrain) and update the changelog to show that there are 3 modules being graudated.

Copy link
Contributor

mergify bot commented Nov 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 29, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a133e80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 187f67b into main Nov 29, 2023
15 checks passed
@mergify mergify bot deleted the sumughan/stabilize-aws-apigatewayv2-alpha branch November 29, 2023 23:36
Copy link
Contributor

mergify bot commented Nov 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Dec 5, 2023
Deletes the `aws-apigatewayv2-alpha`, `aws-apigatewayv2-authorizers-alpha`, and `aws-apigatewayv2-integrations-alpha` modules since they have now been [stabilized](#28094). Also removes references to these deprecated alpha modules.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this pull request Dec 5, 2023
We are excited to graduate the `@aws-cdk/aws-apigatewayv2-alpha`, `@aws-cdk/aws-apigatewayv2-authorizers-alpha`, and `@aws-cdk/aws-apigatewayv2-integrations-alpha` modules to STABLE.

They now live on as:
- `aws-cdk-lib/aws-apigatewayv2`
- `aws-cdk-lib/aws-apigatewayv2-authorizers`
- `aws-cdk-lib/aws-apigatewayv2-integrations`

**Deprecated properties removed**:

- `httpApiId` has been removed in `aws-apigatewayv2`. Use `apiId` instead.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants