chore: make toolkit tests not break Lerna links #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the integ tests are run in the source directroy, the "npm install" command will go up to find package.json and replace its node_modules directory, thereby breaking the Lerna symlinks and making subsequent toolkit executions fail because it can't find '@aws-cdk/cx-api'. Copy out the app directory to a temporary directory and run the test there, so that the source tree remains undisturbed. It's a fixed directory name, seems simpler than generating a temporary directory on each run and then also having to install a cleanup hook.
eladb
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the integ tests are run in the source directroy, the "npm install"
command will go up to find package.json and replace its node_modules
directory, thereby breaking the Lerna symlinks and making subsequent
toolkit executions fail because it can't find '@aws-cdk/cx-api'.
Copy out the app directory to a temporary directory and run the test
there, so that the source tree remains undisturbed.
It's a fixed directory name, seems simpler than generating a temporary
directory on each run and then also having to install a cleanup hook.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.