Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make toolkit tests not break Lerna links #914

Merged
merged 1 commit into from
Oct 12, 2018
Merged

chore: make toolkit tests not break Lerna links #914

merged 1 commit into from
Oct 12, 2018

Commits on Oct 12, 2018

  1. chore: make toolkit tests not break Lerna links 

    If the integ tests are run in the source directroy, the "npm install"
command will go up to find package.json and replace its node_modules
directory, thereby breaking the Lerna symlinks and making subsequent
toolkit executions fail because it can't find '@aws-cdk/cx-api'.

Copy out the app directory to a temporary directory and run the test
there, so that the source tree remains undisturbed.

It's a fixed directory name, seems simpler than generating a temporary
directory on each run and then also having to install a cleanup hook.
    Rico Huijbers committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    f0e0b24 View commit details
    Browse the repository at this point in the history