Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back support for --endpoint-url option to s3 #469

Closed
wants to merge 3 commits into from

Conversation

mguillaume
Copy link
Contributor

The --endpoint-url option was re-enabled with commit d6c46df but s3 uses different code to get the endpoint.
This adds back endpoint-url support for the s3 service.

@mguillaume
Copy link
Contributor Author

Looks like I have to adapt the unit tests too, I'll update ASAP.

@jamesls
Copy link
Member

jamesls commented Nov 6, 2013

Could you also add a unit tests for your change? That way we can ensure we don't regress on this again in the future.

Thanks.

@mguillaume
Copy link
Contributor Author

I think this one does it.
Note that for S3, without specifying a region, endpoint-url will not work as botocore has to do a lot of "magic" associated with region endpoints and DNS compatible endpoints. I have a (pretty simple) pull request in botocore to allow us to use --region=mock for this: boto/botocore#171

@jamesls
Copy link
Member

jamesls commented Nov 7, 2013

Thanks for adding the test, looks good. Looks like there were other changes to s3 recently so there are a few merge conflicts I'll have to work through. Unless of course you wouldn't mind rebasing against develop :)

@mguillaume
Copy link
Contributor Author

This is "rebased" (manually + push -f), but one test does not pass anymore.
I'm not 100% sure but I think the Mock service for s3 doesn't provide everything that is required by the new ListCommand.

@jamesls jamesls closed this in 3a97a37 Nov 18, 2013
@jamesls
Copy link
Member

jamesls commented Nov 18, 2013

Sorry for the delay, this has been merged, thanks!

thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants