Add a "mock" region for which the endpoint URL is not rewritten #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing out old pull request. The internals have changed in botocore have changed quite a bit such that this is possible without having to modify any botocore code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For offline testing (like, when you're on a train), it's nice to be able to use a fake S3 server (eg fakes3).
However, the fix_s3_host function in handlers.py rewrites them to things like http://test.s3.amazonaws.com
This commit adds a fake "mock" region in the RESTRICTED_REGIONS so that custom endpoint_url used with this fake region are not rewritten to valid S3 endpoints. (this may not be the best way to do it, but it has the advantage to be super simple and have little chance to break anything).