-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(stable): fix build issues to prepare for v1.28.0 release #4105
Conversation
355a1b2
to
18bda7c
Compare
We need to temporarily disable the Lines 17 to 25 in 14470b2
Lines 42 to 50 in 14470b2
|
@heiher Thanks for the heads up! I guess removing |
0a31484
to
260500c
Compare
I tested the
|
@heiher Despite being not idiomatic, that's the expected behavior currently, as Lines 251 to 253 in 14470b2
... it'd definitely be nice to add |
@rami3l Thank you. Could you include this patch together as well? diff --git a/src/utils/mod.rs b/src/utils/mod.rs
index dae45d4b..d9a8ee51 100644
--- a/src/utils/mod.rs
+++ b/src/utils/mod.rs
@@ -250,7 +250,8 @@ async fn download_file_(
.is_some_and(|it| it != "0");
let use_rustls = process
.var_os("RUSTUP_USE_RUSTLS")
- .is_none_or(|it| it != "0");
+ .is_none_or(|it| it != "0")
+ && cfg!(feature = "reqwest-rustls-tls");
let (backend, notification) = if use_curl_backend {
(Backend::Curl, Notification::UsingCurl)
} else { |
@heiher Done! I guess it should be working now? |
Acked. 👍 |
Blocking on aws/aws-lc-rs#620. |
Oops, it looks like https://github.com/rust-lang/rust-bindgen/releases/tag/v0.71.0 has suddenly broken everything... Not only are the prebuilt binaries and installer missing (as reported in rust-lang/rust-bindgen#3038, though our fallback to |
I could lock the |
I strongly suspect that rust-lang/rust-bindgen#3039 has caused the build failure; checking Update: theory confirmed (https://github.com/aws/aws-lc-rs/blob/a7a70cbe163b22f6a4cd438ad2d0c668e2fbdc58/aws-lc-sys/builder/main.rs#L700). |
78d77d0
to
bfdc2fb
Compare
As aws/aws-lc-rs#627 is now open, I'll request the team's review first. Of course, I'll finish the checklist before actually merging this PR. |
I'm not yet familiar with rustup's CI setup. Is skip-master kept because we still expect master to fail after this PR is merged? |
@ChrisDenton We don't run everything on master (that's how things had always been done way before my CI refactoring last year), and essentially the only moment we need to make sure all workflows are green is during a release, which is related to the stable CI rather than the master one. I've already triggered the stable CI last week, and it failed; according to the parts that have failed during that run, I have temporarily enabled some workflows just for this PR. They will be disabled again before this PR is merged. |
@ChrisDenton BTW if you're wondering why the master CI is currently failing, that's not related to the build-time behavior, but rather Update: I've made #4111. |
@djc |
Thanks for all the work on this so far! |
Before merging, we should also:
i686-pc-windows-gnu
aws/aws-lc-rs#620 to land in a new release.DROP ME
commit.FWIW, because of
rustls
's migration toaws-lc-rs
, with this PR:reqwest/rustls/aws-lc-rs
combo has become the default download backend on Linux forriscv*
,s390x*
andppc32
platforms.netbsd
andillumos
builds have switched toreqwest/rustls/native-tls
by default.