AES Key Wrap Algorithm Support #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
reviewed
Oct 20, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 95.21% 95.66% +0.45%
==========================================
Files 55 57 +2
Lines 6980 7751 +771
==========================================
+ Hits 6646 7415 +769
- Misses 334 336 +2 ☔ View full report in Codecov by Sentry. |
skmcgrail
force-pushed
the
keywrap
branch
2 times, most recently
from
651c693
to
421497e
Compare
justsmth
reviewed
Nov 15, 2023
skmcgrail
force-pushed
the
keywrap
branch
3 times, most recently
from
ca85f4e
to
9dd7466
Compare
justsmth
reviewed
Nov 29, 2023
justsmth
reviewed
Nov 29, 2023
skmcgrail
force-pushed
the
keywrap
branch
6 times, most recently
from
c43eba6
to
fe99073
Compare
justsmth
previously approved these changes
Dec 13, 2023
skmcgrail
requested review from
WillChilds-Klein
and removed request for
samuel40791765
1 task
justsmth
approved these changes
Jan 5, 2024
WillChilds-Klein
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds
aws_lc_rs::key_wrapmodule that provides AES-128 and AES-256 key wrap algorithms (padded and unpadded variants).Testing:
Pulled a partial set of key wrap tests from the available CAVP tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.